On Wed, 17 Nov 2021 18:48:00 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> Sorry if my point was not clear. I would prefer to have 1 test to exercise a > Zip file comment vs have tests in multiple areas. Expanding the existing test > in this case keeps the primary coverage in one location and makes it easier > for future maintainers. I have preferred to have separate tests for the separate use cases, other than one big testcases which cover all possible combinations of exceptions and parameters. > I am not suggesting to not make your change, I am suggesting to include this > change as well. I understood that you suggest adding this additional change as well, and I pointed out why it is not necessary, if that code will be executed with the long comment it will break the specification. ------------- PR: https://git.openjdk.java.net/jdk/pull/6380
