On Wed, 17 Nov 2021 19:25:33 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> > Sorry if my point was not clear. I would prefer to have 1 test to exercise > > a Zip file comment vs have tests in multiple areas. Expanding the existing > > test in this case keeps the primary coverage in one location and makes it > > easier for future maintainers. > > I have preferred to have separate tests for the separate use cases, other > than one big testcases which cover all possible combinations of exceptions > and parameters. This is really a style choice so I guess we can agree to disagree. Either way it would be preferable to have both tests in the same location. > > > I am not suggesting to not make your change, I am suggesting to include > > this change as well. > > I understood that you suggest adding this additional change as well, and I > pointed out why it is not necessary, if that code will be executed with the > long comment it will break the specification. The additional change simply helps provide a layer of extra protection from corruption creating the zip file. Anyways, I will approve the changes as they are. ------------- PR: https://git.openjdk.java.net/jdk/pull/6380
