On Wed, 23 Feb 2022 15:44:07 GMT, Tyler Steele <d...@openjdk.java.net> wrote:
>> @RogerRiggs
>> Many thanks. that's good point.
>> Only 1st part has `test.nativepath` because of following code.
>>
>> if (AIX.is()) {
>> pb.environment().put("LIBPATH", libpath);
>> }
>>
>> On current condition, parent (main) process have `test.nativepath` setting
>> into LIBPATH environment, but child process does not require
>> `test.nativepath` setting.
>> So just `libpath` value should not have `test.nativepath` related entry.
>> And above code does not require on current condition and this test said
>> "Pass Empty environment to child".
>> So it should be removed.
>>
>> #7581 is exactly same issue.
>> Please choose the appropriate one.
>
> Hi @takiguc 👋, thanks for your changes. I closed my PR in favour of yours; we
> definitely don't need two PRs for this issue :-)
>
> One comment on the approach you took. I considered modifying the static
> libpath variable as well, but what really swayed me away from choosing that
> route is the Windows tests. On Windows, the situation is analogous to AIX in
> that a static systemroot variable is set by querying the parent environment,
> but it is explicitly passed to the child process[es] when they are created.
> This ensures that the systemroot returned by the child process is the same as
> the expected value. Admittedly it's a bit of a nit-pick, but I think having
> the Windows version of the test do one thing and AIX version do another make
> it harder to understand what is going on. It's for that reason that I took
> the approach that I did in my PR.
@backwaterred
I applied change. Please check this one ?
-------------
PR: https://git.openjdk.java.net/jdk/pull/7574
