On Wed, 19 Jan 2022 22:09:26 GMT, Joe Darcy <da...@openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8279508: Adding a test for scalar intrinsification.
>
> The testing for this PR doesn't look adequate to me. I don't see any testing 
> for the values where the behavior of round has been redefined at points in 
> the last decade. See JDK-8010430 and JDK-6430675, both of which have 
> regression tests in the core libs area. Thanks.

Hi @jddarcy , can you kindly validate your feedback, it has been incorporated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7094

Reply via email to