On Fri, 29 Apr 2022 20:34:21 GMT, Mandy Chung <mch...@openjdk.org> wrote:
> I took a closer look at the proposed APIs. I think it's in a good state to > target for 19. I skimmed on the existing JDK usage of `getModifiers` other > than a trivial test e.g. is public, final, etc and the proposed API works > well (btw no plan to convert them and just use those cases for validation). > > The value of `ACC_SUPER` and `ACC_STRICT` could possibly be reused for new > access flags. It may be useful to document when the flag becomes obsolete. > > Nit: the enum constants are listed in the order of the mask value, which I > like. Some enum constants reference the `Modifer` constants but I think it'd > help to see the mask value here consistently for all entries. One go-to place > in the source if I want to find the value of different flags. I've pushed a changeset to add the mask values to the constants' javadoc. Following a don't-repeat-yourself approach, I would have preferred to do this with a @-value tage using the java.lang.reflect.Modifier value (where available), but the @-value tags doesn't seem to offer any formatting so I added the values separately. ------------- PR: https://git.openjdk.java.net/jdk/pull/7445
