On Tue, 3 May 2022 20:00:52 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address review comments > > src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java > line 76: > >> 74: ForkJoinWorkerThread(ThreadGroup group, ForkJoinPool pool, >> 75: boolean useSystemClassLoader, >> 76: boolean clearThreadLocals) { > > It's tempting to toggle the sense of last boolean argument to be > `preserveThreadLocals` for consistency (given the multiple toggles as the > value is propagated from the newly added protected constructor), but which > means toggling the value at the use sites that you may not wish to change. Thanks. I changed param name to clearThreadLocals, which I think helps. I do need (only) one negation somewhere along these paths because internally clearing requires a set config bit. ------------- PR: https://git.openjdk.java.net/jdk/pull/8490