On Tue, 10 May 2022 14:02:14 GMT, Alan Bateman <al...@openjdk.org> wrote:

> > @LanceAndersen @AlanBateman do you think adding the entry name in the 
> > exception in ZipFileSystem is ok? If so, should it maybe go into a 
> > different patch?
> 
> It should be okay as this is the name of an entry in the zip file. It might 
> be a bit cleaner to add a method to IndexNode to return the name as String. 
> Alternatively maybe its toString could be changed to drop the index (I would 
> need to dig into the history to find out if there is really any use for the 
> index in the String representation).

I think this would be OK, but would get to get someone from our security team 
to bless it.  

It might not be a bad idea to add a method to return the name as a String.  
There are a couple of places where we do a new String(name) so would economize 
any future changes

-------------

PR: https://git.openjdk.java.net/jdk/pull/8616

Reply via email to