On Wed, 11 May 2022 05:39:42 GMT, Alan Bateman <al...@openjdk.org> wrote:
> > > It's probably ok, but the bug report is either incomplete or I am missing > > > something. It says "This can be improved to something like: ..." but the > > > same text as is emitted now is used. Can you fix this so I have a better > > > example of what will be included in the message? > > > > > > The bug report also says "The error message does not give a clue which jar > > file is causing the problem" but the error message includes the name > > "invalid.jar" so I am also confused about that. > > There are two parts to it. In the case of initCEN method, the proposed change > is to include the name of the rejected entry in the exception message. This > is not the same thing as leaking a file path in the exception message so I > don't think we have a concern here. Ok, but @RealCLanger can you address the prior comments I had on the bug report? The error messages (before and after the fix) are the same. ------------- PR: https://git.openjdk.java.net/jdk/pull/8616
