On Wed, 27 Apr 2022 15:45:12 GMT, Roger Riggs <rri...@openjdk.org> wrote:

>> I ran `codespell` on modules owned by core-libs, and accepted those changes 
>> where it indeed discovered real typos.
>> I will update copyright years using a script before pushing (otherwise like 
>> every second change would be a copyright update, making reviewing much 
>> harder).
>> The long term goal here is to make tooling support for running `codespell`. 
>> The trouble with automating this is of course all false positives. But 
>> before even trying to solve that issue, all true positives must be fixed. 
>> Hence this PR.
> src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java
>  line 140:
>> 138:             } else if(type == XMLEvent.START_ELEMENT) {
>> 139:                 throw new XMLStreamException(
>> 140:                 "elementGetText() function expects text only element 
>> but START_ELEMENT was encountered.", event.getLocation());
> Should we be fixing typos in third party software; it can easily get wiped 
> out in an update.

No, we should not. Such changes ideally should be brought upstream, but I can't 
be bothered. :-(

I'm reverting all changes in this file. Are there any more files that are 3rd 
party in this fix? I have no way to tell.


PR: https://git.openjdk.java.net/jdk/pull/8364

Reply via email to