On Tue, 17 May 2022 03:05:09 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert change for java.c , parse_manifest.c , LinuxPackage.c > > src/hotspot/share/opto/memnode.cpp line 1413: > >> 1411: bt == T_BYTE || bt == T_SHORT || >> 1412: bt == T_INT || bt == T_LONG, "wrong type = %s", >> type2name(bt)); >> 1413: PRAGMA_DIAG_POP > > The problem here is the definition of type2name, which returns NULL for an > unknown BasicType. It would probably be better if it returned a recognizable > string for that situation, eliminating this warning at it's source. While looking at type2name, I noticed the comment for the immediately preceding type2name_tab is wrong. ------------- PR: https://git.openjdk.java.net/jdk/pull/8646
