On Tue, 17 May 2022 01:43:25 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert change for java.c , parse_manifest.c , LinuxPackage.c
>
> src/hotspot/share/classfile/classFileParser.cpp line 5970:
>
>> 5968: PRAGMA_STRINGOP_OVERFLOW_IGNORED
>> 5969: _cp->symbol_at_put(hidden_index, _class_name);
>> 5970: PRAGMA_DIAG_POP
>
> I don't understand these warning suppressions for symbol_at_put (here and
> elsewhere). I don't see any stringops here. What is the compiler
> complaining about? (There's no mention of classfile stuff in the review
> cover message.)
Like the others, it is caused by `Array::at_put()`.
In file included from
/home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/annotations.hpp:28,
from
/home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/instanceKlass.hpp:29,
from
/home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/javaClasses.hpp:30,
from
/home/ysuenaga/github-forked/jdk/src/hotspot/share/precompiled/precompiled.hpp:35:
In member function 'void Array<T>::at_put(int, const T&) [with T = unsigned
char]',
inlined from 'void ConstantPool::tag_at_put(int, jbyte)' at
/home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/constantPool.hpp:126:64,
inlined from 'void ConstantPool::symbol_at_put(int, Symbol*)' at
/home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/constantPool.hpp:362:15,
inlined from 'void
ClassFileParser::mangle_hidden_class_name(InstanceKlass*)' at
/home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/classFileParser.cpp:5966:21:
-------------
PR: https://git.openjdk.java.net/jdk/pull/8646
