On Fri, 20 May 2022 22:22:43 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> I see that you swapped `src, dst` in `match()` but `format` is sill
>> incorrect and the code is confusing.
>
> I agree with @vnkozlov that this needs explanation. Could you please add
> comments here with IR and example code generated for both the eq case and ne
> case? You have some explanation in the PR description but not in the code.
> The description needs to be in the code as well for maintenance.
Right, I missed that. Then you can use `expand %{` to avoid duplication (keep
format).
-------------
PR: https://git.openjdk.java.net/jdk/pull/8525
