On Tue, 24 May 2022 10:47:15 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/StructuredTaskScope.java >> line 1110: >> >>> 1108: * invoked {@link #join() join} (or {@link >>> #joinUntil(Instant) joinUntil}). >>> 1109: * The behavior of this method is unspecified when invoking >>> this method before >>> 1110: * the {@code join} is invoked. >> >> Suggestion: >> >> * {@link #join} is invoked. > > More generally, I see that you used `{@code ... }` in a lot of places where > `{@link ... }` could also be used. In some of those places (like this one) > where there is a clear cross-reference, I think `@link` could be preferrable. > The only case where `@code` is fine is when referring to the name of the > class itself (e.g. `{@code StructuredTaskScope}`). But of course this is > subjective. Also, note the typo `the join is invoked`. Either `the` is dropped, or `method` is added. I've seen more than one occurrence of this. ------------- PR: https://git.openjdk.java.net/jdk/pull/8787