On Thu, 23 Jun 2022 01:13:17 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> The RuntimeException from OutputAnalyzer for expected and unexpected exit
>> values should include both the actual and expected values.
>> The method `shouldHaveExitvalue` and `shouldNotHaveExitValue` include the
>> value expected and the value not expected instead of the actual value
>> returned. The values provided in the exception are already known quantities
>> in the code, what is not known is the actual value.
>> The actual value is printed to stderr but not the expected value and in the
>> logs, the exception report is frequently to stdout and therefor separated in
>> the log from the output of stderr. Including both expected and actual
>> values in the exception makes it easier to understand.
>>
>> Exception messages should not include newlines.
>
> test/lib-test/jdk/test/lib/process/OutputAnalyzerTest.java line 223:
>
>> 221: try {
>> 222: // Verify the exception message
>> 223: OutputAnalyzer out =
>> ProcessTools.executeProcess("true");
>
> Hello Roger, this test seems to run on all OS. Is `true` available on
> Windows? If yes, does it require a `.exe` suffix?
The Windows CreateProcess API appends ".exe". (if there is no suffix).
(And CI testing succeeded).
-------------
PR: https://git.openjdk.org/jdk/pull/9247
