On Mon, 27 Jun 2022 14:57:30 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> rmartinc has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new commit since the last revision: >> >> 8288895: LdapContext doesn't honor set referrals limit > > src/java.naming/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java > line 339: > >> 337: break; >> 338: } else if (errEx == null) { >> 339: errEx = re.getNamingException(); > > Could we set up a local variable here to avoid calling > re.getNamingException() more than once? > e.g. something like: > > > var cause = re.getNamingException(); > if (cause instanceof ...) { > > > then use `cause` throughout. Yes, of course, I just called the var `namingException` instead of `cause`. It's done now. ------------- PR: https://git.openjdk.org/jdk/pull/9256