On Fri, 15 Jul 2022 19:33:56 GMT, Ryan Ernst <d...@openjdk.org> wrote:
>> This commit guards uses of Files methods returning path streams in
>> java.base to use try-with-resources.
>
> Ryan Ernst has updated the pull request incrementally with one additional
> commit since the last revision:
>
> address formatting feedback
Changes requested by chegar (Reviewer).
src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 262:
> 260: p = module.relativize(p);
> 261: String pkgName = slashesToDots(p.toString());
> 262: // skip META-INFO and empty strings
Trivially, while here can we fix this typo, META-INFO <- drop the `O`
src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 271:
> 269: moduleNames.add(moduleName);
> 270: }
> 271: });
There is a missing closing curly brace here (which should come on the next
line), but otherwise looks fine.
src/java.base/share/classes/jdk/internal/module/ModulePatcher.java line 138:
> 136: stream.filter(path -> (!isAutomatic
> 137: || path.toString().endsWith(".class"))
> 138: && !isHidden(path))
Trivially, can the indentation of the two boolean operators be pushed in so
that they align underneath the lambda parameter.
-------------
PR: https://git.openjdk.org/jdk/pull/9518
