On Mon, 18 Jul 2022 15:35:25 GMT, Chris Hegarty <[email protected]> wrote:
>> Ryan Ernst has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into try_files/jdk.link
>> - fix alignment
>> - 8290359: Ensure that all directory streams are closed in jdk.link
>>
>> This commit adds try-with-resources for uses of Stream<Path> from Files
>> methods that walk directories.
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 834:
>
>> 832: name.endsWith(".EC") ||
>> 833: name.startsWith("META-INF/SIG-")
>> 834: );
>
> Trivially, can we please keep the indentation consistent with the previous
> version. So, align all `name.endsWith` expressions under the 's' from
> startsWith.
Done in
[c628479](https://github.com/openjdk/jdk/pull/9520/commits/c62847976c4a34ee97be61bbac3002513028e87c)
-------------
PR: https://git.openjdk.org/jdk/pull/9520
