On Mon, 18 Jul 2022 19:48:02 GMT, Mark Reinhold <m...@openjdk.org> wrote:
> It’s odd to mix adding some advice to the Javadoc with adopting that advice > in the code base. Consider opening a new issue and PR for the actual code > changes. [JDK-8290504][1] has been filed to track the implementation changes. @rjernst please separate out the implementation changes into a separate PR, using 8290504 as the linked JIRA issue. (apologies, I previously asked for the implementation changes to be in this PR ) > Also, a better summary for this issue (and PR) would be “ModuleReader::list > specification should suggest closing the returned stream,” since that’s the > essence of it. Agreed. I updated the JIRA issue summary as suggested. @rjernst please update the title of this PR to match. [1]: https://bugs.openjdk.org/browse/JDK-8290504 ------------- PR: https://git.openjdk.org/jdk/pull/9538
