On Tue, 26 Jul 2022 10:16:31 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> test/jdk/java/nio/channels/vthread/BlockingChannelOps.java line 36: >> >>> 34: * @test id=useDirectRegister >>> 35: * @bug 8284161 >>> 36: * @summary Basic tests of virtual threads doing blocking I/O with NIO >>> channels >> >> Hello Aleksey, I see that previously the `@bug` and `@summary` was only >> there on one test definition. So maybe remove this duplicated `@bug` and >> `@summary` from this new test definition? >> Other than that, this test change looks OK to me. > > On a related note - I had a brief look at the jtreg docs including the FAQ > https://openjdk.org/jtreg/faq.html and I don't see any mention about how it > treats multiple test definitions in a single source file, when it comes to > running them concurrently. But I believe you have more experience with it and > have already tested the difference in parallelism, so I think what you > suggest here is fine. Yes, this is a usual thing to replicate the test sections. It is also a usual practice to copy-paste the entirety of run definition/config. ------------- PR: https://git.openjdk.org/jdk/pull/9554
