On Fri, 22 Jul 2022 18:32:56 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/lib/native/testlib_threads.h line 50:
>
>> 48: static void fatal(const char* message) {
>> 49: perror(message);
>> 50: exit(-1);
>
> Won't work as intended for Windows APIs. I would print the result of
> `GetLastError()` instead.
>
> Alternatively I am fine fine with just omitting the error code, because I
> think the old tests did not handle errors either. Or did we catch std::thread
> exceptions somewhere?
The intent was to exit the test with a non-zero exit code, in order to avoid
any accidental false positives.
I could return the error code from `GetLastError` and from the respective
pthread apis as an exit code instead. Is that what you mean?
-------------
PR: https://git.openjdk.org/jdk/pull/9599
