On Fri, 5 Aug 2022 17:04:54 GMT, Alex Kasko <aka...@openjdk.org> wrote:

>> This change adds `ContextMenuCommandLabel` l10n property for file 
>> association context menu label. It is a follow-up to [this PR 
>> comment](https://github.com/openjdk/jdk/pull/9224#issuecomment-1169286082).
>> 
>> Note, non-EN l10n values were filled using auto-translator and may need to 
>> be corrected.
>> 
>> To check the contents of the label, registry query is added to 
>> `PackageTest::addHelloAppFileAssociationsVerifier`.
>> 
>> Testing:
>> 
>>  - [x] ran `FileAssociationsTest` with `install` enabled
>
> Alex Kasko has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reg method access, drop l10n entries, label check enhancement

I think there was a miscommunication about l10n files.
All "MsiInstallerStrings_*.wxl" files need to be updated, but no need to 
provide a localized version of English string(s). 
I.e. add `<String Id="ContextMenuCommandLabel">Open with 
[ProductName]</String>` to all "MsiInstallerStrings_*.wxl" files, not only to 
"MsiInstallerStrings_en.wxl".

-------------

PR: https://git.openjdk.org/jdk/pull/9753

Reply via email to