On Mon, 8 Aug 2022 09:06:39 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> I feel stupid > > src/java.base/unix/native/libjli/java_md_common.c line 209: > >> 207: /* >> 208: * TODO: its safer to use strerror_r but is not available on >> 209: * Solaris 8. Until then.... > > We are well past then :) so this should be changed to use strerror_r - though > see ./java.base/unix/native/libjava/jni_util_md.c Using getLastErrorString in the implementation for Unix, the Windows version of getLastErrorString is also broken, just like JLI_ErrorMessageSys, but unlike the latter shared code does use it, so no attempts will be made to fix it ------------- PR: https://git.openjdk.org/jdk/pull/9793
