On Mon, 15 Aug 2022 11:16:06 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> The affected file was added by > [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059), and the code that > fails the compilation is under `#ifdef _WIN32`, and it only (?) gets compiled > for tests. Looks like we really need the "WINAPI" macro in the definition, so > that we match the stdcall. See the example declaration in the > [docs](https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/ms686736(v=vs.85)). > > Attn @JornVernee. > > Additional testing: > - [x] Windows x86_32 builds/test now pass > - [ ] Windows x86_64 builds/test still pass Looks good and trivial. This came up during the original PR discussion but we thought it would not be needed. Cheers, Thomas ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk/pull/9875
