On Wed, 28 Sep 2022 05:45:14 GMT, Ioi Lam <[email protected]> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains one commit:
>>
>> 8293540: [Metrics] Potentially incorrectly detected resource limits with
>> additional cgroup fs mounts
>
> The JDK change looks good to me. Some nits for the test cases.
Thanks for the review @iklam!
> test/jdk/jdk/internal/platform/docker/TestDockerBasic.java line 26:
>
>> 24: /*
>> 25: * @test
>> 26: * @summary Verify that -XshowSettings:system works
>
> Add `@bug 8293540`
Thanks, added.
> test/jdk/jdk/internal/platform/docker/TestDockerBasic.java line 64:
>
>> 62: opts.addDockerOpts("--memory", "300m");
>> 63: if (addCgroupMounts) {
>> 64: opts.addDockerOpts("--volume",
>> "/sys/fs/cgroup:/cgroup-in:ro");
>
> Add comments that the extra mount should be ignored by the cgroup set-up
> code. (Same for other test cases).
OK. Added in the updated version.
-------------
PR: https://git.openjdk.org/jdk/pull/10248
