On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu <d...@openjdk.org> wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal >> only) >> >> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method >> names > > Justin Lu has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust typo within test description Marked as reviewed by lancea (Reviewer). > > should we update > > test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java > > to include `@test, @bug, @run, @summary`? > > Brent actually pointed that out to me as well. I believe since > Bug4170614Test.java is managed by Bug4170614TestRun.java which has tags, then > it would be fine to not include the tags(in Bug4170614Test.java), but please > let me know your thoughts. @LanceAndersen > > should we update > > test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java > > to include `@test, @bug, @run, @summary`? > > Brent actually pointed that out to me as well. I believe since > Bug4170614Test.java is managed by Bug4170614TestRun.java which has tags, then > it would be fine to not include the tags(in Bug4170614Test.java), but please > let me know your thoughts. @LanceAndersen Hi Justin, Yes if the wrapper class is needed then we do not need the tags in the actual test. ------------- PR: https://git.openjdk.org/jdk/pull/10475
