On Wed, 28 Sep 2022 03:40:06 GMT, Yoshiki Sato <ysato...@openjdk.org> wrote:
> Please review this PR. The change include some code changes in
> ZoneInfoFile.java and TestZoneInfo310.java since tzdata2022d breaks
> TestZoneInfo310.java.
Some minor comments
src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java line 588:
> 586: // will not work for Asia/Gaza and Asia/Hebron which
> follow
> 587: // Palestine DST rules.
> 588: // No need of hacking for Plaestine DST rules from
> tz2022d
Should this comment be removed, or at least modified to be better explained?
test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 201:
> 199: zid.equals("Asia/Tehran") || // last rule mismatch
> 200: zid.equals("Asia/Gaza") ||
> 201: zid.equals("Asia/Hebron") ||
It'd be helpful to append `// uses "Palestine" rule`.
-------------
PR: https://git.openjdk.org/jdk/pull/10460
