On Sun, 9 Oct 2022 17:58:37 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment formatting > > src/java.base/share/native/libjli/jli_util.h line 91: > >> 89: * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference >> 90: * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170 >> 91: */ > > I don't think the comment about the *lack* of a workaround is needed, just > adding clutter. But this isn't code I have much involvement with. Other > than that, the change looks fine. I agree, we don't document the absence of a workaround. ------------- PR: https://git.openjdk.org/jdk/pull/10625
