Re: RFR: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher [v6]

[Brent Christian]

On Tue, 18 Oct 2022 19:04:29 GMT, Justin Lu <d...@openjdk.org> wrote:

>> Issue: Formatter unit tests are launched via basic.sh
>> 
>> Fix: Replace basic.sh with a Java test launcher
>> 
>> Note: Java.internal.math was included in the original configuration of 
>> Basic, but I removed it as it was not used within the Basic unit tests 
>> 
>> 
>> Original output on success
>> <img 
>> src="https://user-images.githubusercontent.com/67398801/195936541-bc90db50-8d03-47be-9c4f-95176b19a6a7.png";
>>  width="350" height="350">
>> 
>> 
>> New output on success
>> <img 
>> src="https://user-images.githubusercontent.com/67398801/195936558-f85f4d48-dae2-4c38-aa50-46ef47db3d89.png";
>>  width="350" height="450">
>
> Justin Lu has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Remove testing change
>  - Fix formatter in Basic

Changes requested by bchristi (Reviewer).

test/jdk/java/util/Formatter/Basic.java line 90:

> 88: 
> 89:         if (fail != 0) {
> 90:             throw new RuntimeException(String.format("%d tests: %d 
> failure(s)" +

You might consider including `", first"` with the rest of the message string, 
instead of concatenating it. That line might end up slightly long, but it may 
be worth it.

Also, use `%s` for`first`, as it's a `Throwable` ;)
(You could also perhaps change `first` -> `first.toString()` in the final 
argument to format, to clarify.)

-------------

PR: https://git.openjdk.org/jdk/pull/10715