On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu <ji...@openjdk.org> wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request with a new target base due to a merge or
> a rebase. The incremental webrev excludes the unrelated changes brought in by
> the merge/rebase. The pull request contains four additional commits since the
> last revision:
>
> - Add jdk_vector_sanity test group
> - Merge branch 'master' into JDK-8295970
> - Revert changes in test.yml
> - 8295970: Add jdk_vector tests in GHA
I think the usual style for these files is to maintain original order/sorting.
test/jdk/TEST.groups line 44:
> 42: :jdk_vector_sanity \
> 43: :jdk_svc_sanity \
> 44: :jdk_foreign \
Suggestion:
:jdk_math \
:jdk_svc_sanity \
:jdk_foreign \
:jdk_vector_sanity \
test/jdk/TEST.groups line 80:
> 78: :jdk_svc \
> 79: -:jdk_vector_sanity \
> 80: -:jdk_svc_sanity \
Suggestion:
:jdk_svc \
-:jdk_svc_sanity \
-:jdk_vector_sanity \
test/jdk/TEST.groups line 367:
> 365:
> 366: jdk_vector_sanity = \
> 367: jdk/incubator/vector/AddTest.java \
These should probably be sorted too.
-------------
PR: https://git.openjdk.org/jdk/pull/10879
