On Fri, 28 Oct 2022 21:51:03 GMT, Justin Lu <d...@openjdk.org> wrote:
> Issue: Duplication of methods between Basic*.java test classes, due to auto > generation by genBasic.sh > > Fix: Reorganize parts of Basic-X.java.template into base class in Basic.java. > Toggled -nel flag for generation script (genBasic.sh) to remove excessive > white space. Moved a previous direct change to BasicDateTime.java into the > template. > > Note: Main files to look at are Basic.java and Basic-X.java.template, as the > rest are a reflection of the auto generation This pull request has now been integrated. Changeset: f84b0ad0 Author: Justin Lu <justin...@oracle.com> Committer: Brent Christian <bchri...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f84b0ad07c73c305d21c71ec6b8195dc1ee31a3e Stats: 29646 lines in 22 files changed: 1511 ins; 27888 del; 247 mod 8295670: Remove duplication in java/util/Formatter/Basic*.java Reviewed-by: bchristi, lancea, naoto ------------- PR: https://git.openjdk.org/jdk/pull/10910