On Tue, 15 Nov 2022 17:13:58 GMT, Jorn Vernee <[email protected]> wrote:
>> src/hotspot/cpu/aarch64/vmstorage_aarch64.inline.hpp line 68:
>>
>>> 66: }
>>> 67:
>>> 68: inline VMStorage as_VMStorage(Register reg) {
>>
>> Mark as `constexpr` maybe?
>
> Tried this before when `Register` wasn't as `constexpr` friendly due to the
> reinterpret casts. Seems to work now though (thanks! :)) I'll change all
> these to `constexpr`.
Err, looks like this works for MSVC, but with GCC I hit a snag eventually (it
also require putting `constexpr` on a lot of the `Register`/`VMReg` API).
This error occurs:
* For target hotspot_variant-server_libjvm_objs_downcallLinker.o:
In file included from
/mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/vmstorage.inline.hpp:100,
from
/mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/foreignGlobals.hpp:29,
from
/mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/downcallLinker.hpp:27,
from
/mnt/h/openjdk/foreign-abi/src/hotspot/share/prims/downcallLinker.cpp:25:
-------------
PR: https://git.openjdk.org/jdk/pull/11019
