On Wed, 16 Nov 2022 03:54:31 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments.
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 564:
>
>> 562:
>> 563: for (int i = 0; i < length; i++) {
>> 564: objArray[i] =
>> (jthreadGroup)JNIHandles::make_local(groups->obj_at(i));
>
> Nit: It is better to use `jni_reference` instead of `JNIHandles::make_local`
> for consistency as at the line 549.
jni_reference takes a Handle and this passes a Handle to an objArray so
groups->obj_at(i) is an oop and it's a waste to make it a handle for
jni_reference to just unhandlize it.
-------------
PR: https://git.openjdk.org/jdk/pull/11033
