On Wed, 16 Nov 2022 15:54:49 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wrong line separator
>
> src/java.base/share/classes/java/lang/template/ProcessorLinkage.java line 48:
>
>> 46: */
>> 47: @PreviewFeature(feature=PreviewFeature.Feature.STRING_TEMPLATES)
>> 48: public sealed interface ProcessorLinkage permits FormatProcessor {
>
> Does this need to be exposed? FormatProcessor is the only permitted type, so
> javac could detect that (or have an internal list of supported optimized
> processors).
Not worth changing at this point. The plan is to replace with
TemplateProcessorFactories.
> src/java.base/share/classes/java/lang/template/StringProcessor.java line 31:
>
>> 29:
>> 30: /**
>> 31: * This interface simplifies declaration of
>
> Suggestion:
>
> * This interface simplifies the declaration of
Changing.
> src/java.base/share/classes/java/lang/template/ValidatingProcessor.java line
> 86:
>
>> 84: * Composing allows user control over how the result is assembled. Most
>> often, a
>> 85: * user will construct a new string from the template string, with
>> placeholders
>> 86: * replaced by stringified objects from the values list.
>
> stringified looks funny - but have no idea on how to replace it
* Composing allows user control over how the result is assembled. Most often, a
* user will construct a new string from the string template, with placeholders
* replaced by string representations of value list elements. These string
* representations are created as if invoking {@link String#valueOf}.
> src/java.base/share/classes/java/lang/template/ValidatingProcessor.java line
> 126:
>
>> 124: * }
>> 125: * The {@link StringTemplate#interpolate()} method is available for
>> those processors
>> 126: * that just need to work with the interpolation;
>
> again, would be better to replace all bare occurrence of "interpolation" with
> "string interpolation"
Changing.
-------------
PR: https://git.openjdk.org/jdk/pull/10889
