On Thu, 24 Nov 2022 09:27:04 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> src/jdk.incubator.concurrent/share/classes/jdk/incubator/concurrent/ScopedValue.java >> line 209: >> >>> 207: final int bitmask; >>> 208: >>> 209: private static final Object NIL = new Object(); >> >> Suggestion: >> >> static final Object NO_VALUE = new Object(); > > It not very important, but I'm going to push back (very gently) on this one. > "nil: noun. nothing; naught; zero. adjective. having no value or existence." > That is the exact literal meaning of this sentinel. Also, "nil" has been used > with this meaning in programming languages for 60 years. What is your > objection to it here? I agree its not very important, please feel free to ignore my suggestion. My thinking was to prefer something more explicit in the code when reading, since i felt the use of the term nil was more idiomatic in other languages than Java. ------------- PR: https://git.openjdk.org/jdk/pull/10952
