On Wed, 7 Dec 2022 18:57:19 GMT, Alan Bateman <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressing review comments
>
> src/java.base/share/classes/java/io/ProxyingConsole.java line 167:
>
>> 165: @Override
>> 166: public void close() throws IOException {
>> 167: r.close();
>
> Console specifies that the invoking close on the Reader and Writer does not
> close the underlying stream. So I think this close (and
> WrappingWriter::close) need to be a no-op too.
Right. Made them as no-op.
-------------
PR: https://git.openjdk.org/jdk/pull/11421