On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves <igra...@openjdk.org> wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to >> take the same types of arguments as jmod, thus bringing the two into >> alignment. This likely requires a CSR and a discussion on whether we should >> deprecate or simply remove the original numeric compression arguments. > > Ian Graves has updated the pull request incrementally with one additional > commit since the last revision: > > Swapping deprecations in properties Unrelated to the changes in this PR, the `--compress` option allows the value `1` to be specified, which implies "Constant string sharing" and enables the `jdk.tools.jlink.internal.plugins.StringSharingPlugin` which as per its documentation, states: > A Plugin that stores the image classes constant pool UTF_8 entries into the > Image StringsTable. Would there ever be a case where it would be beneficial to have this `StringSharingPlugin` enabled and also set a zip compression? The `DefaultCompressPlugin`, `ZipPlugin` and the `CompressorPluginTest` would need an update for the copyright years. ------------- PR: https://git.openjdk.org/jdk/pull/11617
