On Mon, 12 Dec 2022 20:53:27 GMT, Ian Graves <[email protected]> wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on whether we should
>> deprecate or simply remove the original numeric compression arguments.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Swapping deprecations in properties
test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 153:
> 151: Properties optionsZip0 = new Properties();
> 152: DefaultCompressPlugin compressPluginZip0 = new
> DefaultCompressPlugin();
> 153: options0.setProperty(compressPluginZip0.getName(), "zip-0");
I suspect this supposed to be `optionsZip0.setProperty(....)` instead of
`options0.setProperty(....)`?
test/jdk/tools/jlink/plugins/CompressorPluginTest.java line 203:
> 201: if (e.getMessage().contains("Invalid compression level")) {
> 202: return;
> 203: }
Should we print the stacktrace if the message is not the one we expect, to help
debug any failures? Or perhaps rethrow the exception to cause the test to fail?
-------------
PR: https://git.openjdk.org/jdk/pull/11617
