On Tue, 10 Jan 2023 00:26:13 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add additional (c) years
>
> src/java.base/share/classes/java/io/DataInputStream.java line 582:
>
>> 580: * @see java.io.DataInputStream#readUnsignedShort()
>> 581: */
>> 582: public static String readUTF(DataInput in) throws IOException {
>
> I remember a few years ago asked to create a CCC to remove the final keyword
> of the method in the final class. This change seems broader, probably the
> rules are changed since then, but this one actually may affect the method
> signature. And subclasses will allow hiding this method.
Now that you bring it up, a final modifier on static methods does show up in
the javadoc, and is included in signature tests too.
@minborg I agree the final modifier doesn't make sense here but I think it will
need a CSR to track the sig change.If you don't want to do that then just drop
this part, and it can be done separately.
-------------
PR: https://git.openjdk.org/jdk/pull/11848
