On Wed, 25 Jan 2023 18:45:04 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> This issue was found during the review of this PR: 
>> https://github.com/openjdk/jdk/pull/12132 where `Charset` class was 
>> loaded/initialized at the phase 1 of the startup process. Since `Charset` 
>> depends on `StaticProperty`, loading of `Charset` class should be delayed. I 
>> basically moved cache for `jnuCharset` into the actual calling locations 
>> `ProcessImpl` and `ProcessEnvironment` for unix platforms so that 
>> initPhase1() won't initialize `Charset` class.
>> Unrelated, but I replaced `Locale.ENGLISH` with `Locale.ROOT` in the 
>> argument of `toLowerCase()`.
>
> Naoto Sato has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use standardProvider to determine the default charset

`Charset.defaultCharset()` now uses 
`standardProvider.charsetForName(<file.encoding>)` charset.

-------------

PR: https://git.openjdk.org/jdk/pull/12171

Reply via email to