On Tue, 31 Jan 2023 16:19:34 GMT, Aleksei Efimov <aefi...@openjdk.org> wrote:
> The proposed change adds a new exception handler method to the > `test/jdk/com/sun/jndi/ldap/lib/BaseLdapServer.java` LDAP test library class. > It will allow LDAP tests to customize the handling of server-side exceptions. > > The current `BaseLdapTestServer` implementation prints an exception and its > stack trace to the standard error stream. > > Existing tests in `test/jdk/com/sun/jndi/ldap` that use the modified library > class are passing with the modified version. Hello Aleksei, the change looks fine to me. The new method name `handleSocketException` could be a bit confusing since it might indicate this is about handling `java.net.SocketException`. But I think, given that this is just a test library code and that the method has a comment explaining when it's called, I think it's OK. ------------- Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/12347
