On Wed, 8 Feb 2023 11:37:14 GMT, Alan Bateman <[email protected]> wrote:
>> 1. test/jdk/jni/nullCaller/NullCallerTest.java
>> 2. test/jdk/java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java
>> 3. test/hotspot/jtreg/runtime/jni/CalleeSavedRegisters/FPRegs.java
>>
>> The above tests were blocked on AIX [@require os.family != "aix"]
>> because these tests are failing to call JNI_CreateJavaVM. This is solved by
>> implementing JNI_CreateJavaVM call via POSIX threads.
>> Similarly there are tests which are not blocked and still failing to call
>> JNI_CreateJavaVM on AIX :
>>
>> 4. test/hotspot/jtreg/runtime/jni/daemonDestroy/TestDaemonDestroy.java { PR
>> : [12006](https://github.com/openjdk/jdk/pull/12006) }
>> 5. test/lib-test/jdk/test/lib/process/TestNativeProcessBuilder.java
>>
>> The reported issue : [8300139](https://bugs.openjdk.org/browse/JDK-8300139l)
>
> test/jdk/jni/nullCaller/exeNullCallerTest.cpp line 206:
>
>> 204: #else
>> 205: run(&argv);
>> 206: #endif //AIX
>
> The tests in test/jdk use 4 space indent rather than 2. Otherwise the changes
> to these tests look okay, just a bit annoying to have the same #ifdef AIX ...
> #endif code copied into each test.
Thank you @AlanBateman, I will update with the indentation fixes.
[12006](https://github.com/openjdk/jdk/pull/12006) was a parent issue. I
thought to make a PR [12302](https://github.com/openjdk/jdk/pull/12302) for
other tests after the changes for PR
[12006](https://github.com/openjdk/jdk/pull/12006) is accepted by the community.
-------------
PR: https://git.openjdk.org/jdk/pull/12302
