On Thu, 16 Feb 2023 23:04:30 GMT, Mandy Chung <[email protected]> wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional updates
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java
> line 95:
>
>> 93: switch (level) {
>> 94: case LEVEL_0:
>> 95: System.err.println("warning - the \"0\" value for
>> --compress has been deprecated and " +
>
> I expect this be a localized message, e.g. add to plugins.properties. You
> can call `AbstractPlugin::getMessage` to get the message from the resource
> bundle. This one should be consistent with the existing convention but
> unfortunately the existing warning messages are not consistent - prefixing
> with "Warning:" or "WARNING:".
Thanks. I note that there is a non-localized warning done this way elsewhere in
jlink. May need to make a bug to localize this.
-------------
PR: https://git.openjdk.org/jdk/pull/11617
