On Wed, 22 Feb 2023 16:17:11 GMT, Alan Bateman <[email protected]> wrote:
>> Executors.newSingleThreadExecutor returns a delegating ExecutorService that
>> has finalizer to shutdown the underlying TPE when the wrapper is
>> finalizable. It goes back to JDK 6 and JDK-6399443. This is the last
>> non-empty finalizer in java.base. Removing it will likely lead to bug
>> reports/complaints as the current behavior goes back to 2006. So the
>> proposal is to just replace it with a Cleaner, trivially done in this case.
>> As part of the changes, I've replaced the existing test with a more modern
>> test that exercises more scenarios.
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains five additional
> commits since the last revision:
>
> - Keep reference to Cleanable
> - Merge
> - Fix typo in comment, remove blank line
> - Replace older test
> - Initial commit
src/java.base/share/classes/java/util/concurrent/Executors.java line 844:
> 842: @Override
> 843: public void shutdown() {
> 844: cleaner.clean();
Hmmm... so now shutdown no longer requires permission. You should probably call
super.shutdown() before invoking cleaner.clean(), assuming that shutdown() can
be called twice.
-------------
PR: https://git.openjdk.org/jdk/pull/12675
