On Thu, 23 Feb 2023 16:40:32 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Add the ability to repeatedly append char and CharSequence data to
>> StringBuilder/StringBuffer.
>
> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1918:
>
>> 1916: }
>> 1917: int valueLength = length << UTF16;
>> 1918: if ((Integer.MAX_VALUE - this.count) / count < valueLength) {
>
> I think you can omit this check; the call to ensureCapacityInternal will
> guard against the needed size.
You may be right - I looked over ensureCapacityInternal a few times, just
noticing the signed shift. Thx.
-------------
PR: https://git.openjdk.org/jdk/pull/12728
