On Fri, 3 Mar 2023 21:44:24 GMT, Paul Sandoz <[email protected]> wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fixed AccessFlags javadoc
>> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform
>> - removed obsolete generic parameter from AbstractDirectBuilder
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractInstruction.java
> line 683:
>
>> 681: public UnboundInstruction(Opcode op, int size) {
>> 682: super(op, size);
>> 683: }
>
> Unused?
fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/AnnotationReader.java
> line 99:
>
>> 97: }
>> 98:
>> 99: public static List<List<Annotation>>
>> readParameterAnnotations(ClassReader classReader, int p, boolean isVisible) {
>
> Parameter `isVisible` is unused, but method is called with true/false values.
fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java
> line 76:
>
>> 74: }
>> 75:
>> 76: List<? extends Attribute<?>> attributes() {
>
> Unused
fixed, thanks.
> src/java.base/share/classes/jdk/internal/classfile/impl/BufferedMethodBuilder.java
> line 54:
>
>> 52: private final List<MethodElement> elements = new ArrayList<>();
>> 53: private final SplitConstantPool constantPool;
>> 54: private final ClassEntry thisClass;
>
> Unused. Can be removed as can the associated constructor parameter.
fixed, thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
