On Fri, 25 Nov 2022 14:38:55 GMT, Adam Sotona <[email protected]> wrote:
> 8294962: java.base jdk.internal.module package uses ASM to modify and write
> module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java line
184:
> 182: clb.with(ModuleAttribute.of(ma.moduleName(),
> ma.moduleFlagsMask(), clb.constantPool().utf8Entry(v.toString()),
> ma.requires(), ma.exports(), ma.opens(), ma.uses(), ma.provides()));
> 183: } else {
> 184: clb.accept(cle);
Can you re-format this so that it's consistent with the existing code? Wildly
long lines (180+ chars in this case) make it impossible to use side-by-side
views when looking at changes.
-------------
PR: https://git.openjdk.org/jdk/pull/11368
