On Fri, 10 Mar 2023 15:10:01 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> 8294962: java.base jdk.internal.module package uses ASM to modify and write >> module-info.class. >> This patch converts it to use Classfile API. >> >> Please review. >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > ModuleInfoWriter improvements src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line 157: > 155: var t = new > InvalidModuleDescriptorException(iae.getMessage()); > 156: t.initCause(iae); > 157: throw t; Do happen to remember which test fails if you drop the catching of IAE? I'm asking because InvalidModuleDescriptorException is the exception when parsing a Module attribute, not when writing. ------------- PR: https://git.openjdk.org/jdk/pull/11368
