On Thu, 16 Mar 2023 10:47:01 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> remaining cleanup in SystemModulesPlugin
Looks good. I reviewed the changes in all plugins except IncludeLocalePlugin
and will re-review it once you restore to the previous version.
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
line 79:
> 77: import jdk.internal.classfile.ClassBuilder;
> 78: import jdk.internal.classfile.Classfile;
> 79: import jdk.internal.classfile.Opcode;
this import is unused now.
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java
line 577:
> 575: * Generate SystemModules class
> 576: */
> 577: public byte[] getClassWriter(Configuration cf) {
This method no longer returns a class writer and should be renamed. What
about `genClassBytes`?
-------------
PR: https://git.openjdk.org/jdk/pull/12944
