On Tue, 21 Mar 2023 06:11:57 GMT, Joe Darcy <da...@openjdk.org> wrote:
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review
> first.
>
> Note that since IEEEremainder was the last native method in StrictMath.java,
> the StrictMath.c file needed to be deleted (or modified) since StrictMath.h
> was no longer generated as part of the build. (StrictMath.c was one of the
> file deleted as part of JDK-8302801).
>
> For testing, Mach 5 tier 1 through 3 were successful (other than an unrelated
> test failure that was problem listed) and the exhaustive test was locally run
> and passed with "16, 16" to increase the testing density.
src/java.base/share/classes/java/lang/FdLibm.java line 3337:
> 3335: }
> 3336: x = Math.abs(x);
> 3337: p = Math.abs(p);
Suggestion:
x = Math.abs(x);
p = Math.abs(p);
src/java.base/share/classes/java/lang/FdLibm.java line 3371:
> 3369:
> 3370: // purge off exception values
> 3371: if((hy | ly) == 0 || (hx >= 0x7ff0_0000)|| // y = 0,
> or x not finite
Suggestion:
if ((hy | ly) == 0 || (hx >= 0x7ff0_0000)|| // y = 0, or x
not finite
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13113#discussion_r1143236600
PR Review Comment: https://git.openjdk.org/jdk/pull/13113#discussion_r1143236820
