Re: RFR: 8304691: Remove jlink --post-process-path option [v2]

[Mandy Chung]

On Wed, 22 Mar 2023 16:25:51 GMT, Ian Graves <igra...@openjdk.org> wrote:

>> Removing the hidden `jlink --post-process-path` option.
>
> Ian Graves has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updates per feedback

`test/jdk/tools/lib/tests/JImageGenerator` references this option and needs 
update.

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 392:

> 390:         ExecutableImage img = 
> DefaultImageBuilder.getExecutableImage(existingImage);
> 391:         if (img == null) {
> 392:             throw taskHelper.newBadArgs("err.existing.image.invalid");

"err.existing.image.invalid" can be removed from `jlink.properties.`

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line 265:

> 263:                 Path path = Paths.get(arg);
> 264:                 if (!Files.exists(path) || !Files.isDirectory(path)) {
> 265:                     throw newBadArgs("err.image.must.exist", path);

"err.image.must.exist" can be removed from `jlink.properties`

-------------

PR Review: https://git.openjdk.org/jdk/pull/13126#pullrequestreview-1353383619
PR Review Comment: https://git.openjdk.org/jdk/pull/13126#discussion_r1145341533
PR Review Comment: https://git.openjdk.org/jdk/pull/13126#discussion_r1145339835